Deprecate Dice from classification and re-add to segmentation
#2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
added
bug / fix
github-actions
bot
added
documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2725 +/- ##
======================================
Coverage 69% 69%
======================================
Files 338 340 +2
Lines 18334 18430 +96
======================================
+ Hits 12586 12670 +84
- Misses 5748 5760 +12 |
for more information, see https://pre-commit.ci
Borda
reviewed
Sep 13, 2024
Borda
reviewed
Sep 13, 2024
…/torchmetrics into newmetric/move_dice
for more information, see https://pre-commit.ci
Borda
force-pushed
the
master
branch
2 times, most recently
from
d0a5568
to
9fc79ae
Compare
Borda
force-pushed
the
newmetric/move_dice
branch
from
ad73da5
to
88cc2c5
Compare
for more information, see https://pre-commit.ci
SkafteNicki
requested review from
lantiga,
justusschock and
stancld
as code owners
Borda
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Going to deprecate the current implementation of
dicefrom the classification domain. It is completely outdated because it was not updated back in v0.11 as all the other classification metrics, mainly due to it in principal being equal tof1score if we look at the math.As it is being deprecated a new version is going to be added to the segmentation domain such that we both have dice and generalized dice for that domain. At the same time I make sure the new implementation will fix all issues related to the old implementation:
Fixes #2323
Fixes #2262
Fixes #1602
Fixes #1425
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2725.org.readthedocs.build/en/2725/